🦋Update provider account Invitations index page #3923
Conversation
| flash[:success] = 'Invitation will be resent soon.' | ||
| redirect_to provider_admin_account_invitations_path | ||
| end | ||
| format.xml { head :ok } |
There was a problem hiding this comment.
Are you sure this is not used anymore?
There was a problem hiding this comment.
No, not really but it was added 10+ years ago and I think XML responses are only used by API endpoints.
There is nothing about it in 3scale API docs.
There was a problem hiding this comment.
UPDATE: After some digging I can't really justify removing this response so I will restore it and add a comment for posterity.
josemigallas
force-pushed
the
THREESCALE-9883_invitations_index
branch
from
3e8332c
to
3d3d5af
Compare
| # def sent_date(invitation) | ||
| # invitation.sent_at&.to_s(:long) || 'Not sent yet' | ||
| # end | ||
|
|
||
| # def status(invitation) | ||
| # invitation_status(invitation) | ||
| # # if invitation.accepted? | ||
| # # "yes, on #{invitation.accepted_at.to_s(:short)}" | ||
| # # else | ||
| # # 'no' | ||
| # # end | ||
| # end |
There was a problem hiding this comment.
Better don't push commented code IMO
| # end | ||
|
|
||
| def can_manage_invitation?(invitation) | ||
| @can_manage_invitation ||= @ability.can?(:manage, invitation) |
There was a problem hiding this comment.
This looks wrong, after the first call, it will cache the value of @ability.can?(:manage, invitation) and return it on subsequent calls even when called with different invitation
There was a problem hiding this comment.
I think it would actually work in this case, because for the provider users the abilities are for the whole class, there is no condition that would make it different for different invitations - it's either allowed for all, or not allowed for all.
But I agree that still it's not right 😬
| @@ -1,3 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # TODO: remove and use presenter | |||
There was a problem hiding this comment.
If there are only two small methods left here, why not move them to the presenter directly instead of leaving a TODO?
THREESCALE-9883: Add a toolbar to the table
### Before
After